-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DHCPv6 leases status: Display manufacturer info #4527
DHCPv6 leases status: Display manufacturer info #4527
Conversation
Display info about manufacturers of devices based on their MAC addresses.
Get MAC addresses not only from NDP, but also from DUID of certain types.
For discussion: what if we put MAC and manufacturer information into a separate column like it is done on DHCPv4 leases status page? |
Can you revisit your code on top of the latest code? The page was refactored. I also removed the unused MAC database setup but that doesn't mean it can't be added back :) For details see #4642 |
@fichtner No problem, but I'm not sure how to work on the code when the changes you have already merged are not released yet. Although I know it's generally discouraged, I use a real device to make and test some changes and I prefer it being equipped with a stable version. |
I'll let you know when these are shipped. Most likely it will indeed be 21.1.5. |
@vnxme did you take a look at this in 21.1.4 yet? :) |
Sorry I meant 21.1.5 of course. |
@fichtner As agreed, I revisited the code and implemented a more creative idea: underline the MAC part of each applicable DUID, add vendor data (if any) below, add an NDP MAC and the corresponding vendor data (if any) further below (when using CARP, DUID MACs are not equal to NDP MACs), remove MAC/vendor data from the hostname column. Now the DUID column may look like that: |
@fichtner Great, thank you! Resolved a conflict for this PR to be mergeable. |
merged, thanks! |
@vnxme nice work, this is great :) |
o Display info about manufacturers of devices based on their MAC addresses. o Get MAC addresses not only from NDP, but also from DUID of certain types.
Issues in status_dhcpv6_leases.php for which this PR suggests a solution:
Other:
This PR is a part of changes proposed by #4514.