Add option for webgui and ssh to configure management IP #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
8191
reviewed
Jan 7, 2021
|
@fraenki Just in case you did not recognize: I added a comment in an already resolved review comment... |
Co-authored-by: Manuel Faux <8191@users.noreply.github.com>
Co-authored-by: Manuel Faux <8191@users.noreply.github.com>
Co-authored-by: Manuel Faux <8191@users.noreply.github.com>
Co-authored-by: Manuel Faux <manuel@conf.at>
Co-authored-by: Manuel Faux <manuel@conf.at>
Co-authored-by: Manuel Faux <manuel@conf.at>
|
I've rebased this against current master and resolved the merge conflict. @8191 Thanks for your review! |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Howdy. In #4541 I've suggested to implement a workaround for a problem. The discussion made me realize that this was not the best approach.
Description
This PR contains a new solution that finally adresses the underlying issue and adds a simple option to make the management IP configurable. Let me know what you think.
Compared to #4541 this approach...
In case you agree to merge this new option, then I'll happily update the documentation to include a description for the new option.
Screenshots
Default: listen on specified interfaces
Optional: listen on specified IP
(The option was added to both WebGUI and SSH, but they look the same so I've only added screenshots for the WebGUI option.)