Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics->pfTables: sort before slice #4699

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

kulikov-a
Copy link
Member

@kulikov-a kulikov-a commented Feb 12, 2021

Hi!
sorry, did not take into account when I made #4579
should sort before slice for correct column sorting (now sorting sliced part of ip-sorted array)
closes #4577 correctly

@AdSchellevis AdSchellevis self-assigned this Mar 8, 2021
@AdSchellevis AdSchellevis merged commit d7c67bd into opnsense:master Mar 14, 2021
@AdSchellevis
Copy link
Member

@kulikov-a thanks!

@AdSchellevis AdSchellevis added the cleanup Low impact changes label Mar 14, 2021
AdSchellevis pushed a commit that referenced this pull request Mar 14, 2021
@kulikov-a
Copy link
Member Author

@AdSchellevis thanks!!

@kulikov-a kulikov-a deleted the patch-8 branch March 14, 2021 12:43
fichtner pushed a commit that referenced this pull request Mar 28, 2021
(cherry picked from commit d7c67bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Low impact changes
Development

Successfully merging this pull request may close these issues.

Ability to sort on columns in Firewall: Diagnostics: pfTables
2 participants