Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates/Trust: first step towards MVC for certificate management #5483

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

8191
Copy link
Member

@8191 8191 commented Jan 17, 2022

Draft PR to indicate that something is going on in that direction. And maybe some first feedback if the change itself is desired.

Open points:

  • Legacy implementation also deletes all certificates of a CA when deleting the CA. I personally think that's not really desired and therefore did not implement this in this PR. ➡️ Requires final decision
  • It is (and also was in legacy impl.) possible to delete a CRL which is assigned to an OpenVPN server.
  • Intensive testing

@AdSchellevis AdSchellevis self-assigned this Jan 17, 2022
@AdSchellevis
Copy link
Member

I'm not against refactoring the Trust section, I'm just not sure we can spend enough time to make this happen short time. It might also be easier to start isolating the search functionality by the way so less code is being copied around, currently we are quite busy preparing for 22.1, but don't let me hold you from progressing this further.

@8191
Copy link
Member Author

8191 commented Jan 17, 2022

I'm just not sure we can spend enough time to make this happen short time

I didn't expect this to be merged any soon. It's a crucial functionality, so better longer testing than a broken PKI... 😀

Maybe a candidate for 22.7.

@8191 8191 marked this pull request as ready for review January 21, 2022 00:25
@8191
Copy link
Member Author

8191 commented Mar 27, 2022

@AdSchellevis If you have time to look at this, just give me a hint upfront so that I can rebase onto the current master...

@AdSchellevis
Copy link
Member

@8191 I'll keep it on the list, but given the amount of time needed to review and test this, it might take a while (it's not on the top of my priority list)

@Marvo2011
Copy link

Any news to this? I want to get access to certificates (and users) from the API. Looks that is planed for 23.7?

@fichtner
Copy link
Member

There is no plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants