Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/theme-cicada: in 23.7.6 anything with drop down menu disappeared #3616

Closed
HakunMatat4 opened this issue Oct 12, 2023 · 9 comments
Closed
Assignees
Labels
bug Production bug

Comments

@HakunMatat4
Copy link

Describe the bug

Firewall Live log no longer displays the filters and the templates I had saved.
I have just updated it with the latest update so this is a bug introduced with the update:

OPNsense 23.7.6-amd64
FreeBSD 13.2-RELEASE-p3
OpenSSL 1.1.1w 11 Sep 2023

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Firewall'
  2. Click on 'Log Files'
  3. Click on 'Live view'

Expected behavior

All the filters options and the templates I have created and was working just fine should be there but everything disappeared.
You can see the gif below, it is logging things just fine and the time is right too.

Screenshots

Peek 2023-10-12 15-54

Relevant log files

Gif above, data is being logged just fine, general and plain view looks correct.

Additional context

N/A other than it has been running fine for yearS with S and this is the first bug I am aware of.
I have been exploring the firewall and its logs a lot to block IoT, everything was perfectly fine prior to the update.

Environment

Software version used and hardware type if relevant, e.g.:

OPNsense 23.7.6-amd64
FreeBSD 13.2-RELEASE-p3
OpenSSL 1.1.1w 11 Sep 2023

Intel(R) Core(TM) i5-4210U CPU ( Proxmox)

@HakunMatat4 HakunMatat4 changed the title Firewall Log is broken Firewall Log is broken after the latest update Oct 12, 2023
@fichtner
Copy link
Member

Cicada theme I suppose?

@fichtner fichtner added the support Community support label Oct 12, 2023
@HakunMatat4
Copy link
Author

HakunMatat4 commented Oct 12, 2023

Cicada theme I suppose?

Yes and actually, it is not just the firewall, everything with drop down menu disappeared, they are all blank like that gif

I took a snapshot (Proxmox) before the update and this isn't blocking me yet to restore the snapshot so hopefully, this is a quick fix.

Let me change the title.

@HakunMatat4 HakunMatat4 changed the title Firewall Log is broken after the latest update After the latest update, anything with drop down menu disappeared, is blank. Oct 12, 2023
@HakunMatat4
Copy link
Author

Thank you for the reply.

@fichtner fichtner transferred this issue from opnsense/core Oct 12, 2023
@fichtner fichtner changed the title After the latest update, anything with drop down menu disappeared, is blank. misc/theme-cicada: in 23.7.6 anything with drop down menu disappeared Oct 12, 2023
@fichtner fichtner self-assigned this Oct 12, 2023
@fichtner fichtner added bug Production bug and removed support Community support labels Oct 12, 2023
@fichtner
Copy link
Member

Something very odd here. I fixed the obvious visibility issue with the drop down and will hotfix now... c9f3c7b

@HakunMatat4
Copy link
Author

Something very odd here. I fixed the obvious visibility issue with the drop down and will hotfix now... c9f3c7b

Thank you for looking into it, will check the update within a few days.

@HakunMatat4
Copy link
Author

Fixed with os-theme-cicada 1.34_2, everything is back to normal.
Thank you legends

@hashbanged
Copy link

Thank you @fichtner for the super fast work and all you do. The 1.34_2 patch has my dropdowns visible again.

I don't know that the following qualifies the issue for reopening, but the patched removal of position: absolute on the dropdown-menu class forces the menu content container to push other elements down (Figure 1). Reverting this one change prevents this (Figure 2), which I believe matches the previous behavior. Please note that I haven't tested this from a build change, and I may be missing something important.

before
Figure 1. The 1.34_2 patch removal of position: absolute pushes elements down when the menu is expanded.

after
Figure 2. Adding absolute positioning to .dropdown-menu preserves the menu container height.

@fichtner
Copy link
Member

See b276276 😊

@hashbanged
Copy link

Like magic. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Production bug
Development

No branches or pull requests

3 participants