New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www/caddy: Domain presentation under Handlers #3884
Comments
This is by design, since you could create: And then there would be just "foo.example.com" 3 times in the handlers. I tried to show a mix of domain name and port with the model relation field, but I didn't get it to work, so I defaulted for a required description. EDIT: I can solve it like this, then the description can be chosen more freely.
|
Monviech
added a commit
to Monviech/opnsense-plugins
that referenced
this issue
Apr 4, 2024
to allow displaying multiple elements instead of only the description. This prevents duplicates being displayed without being able to know which entry is which. Possibly fixes: opnsense#3885 opnsense#3884 Also, since the descriptions are used by "internalModelUseSafeDelete", it's better to make them all required.
AdSchellevis
pushed a commit
that referenced
this issue
Apr 11, 2024
* Update ReverseProxyController.php Update searchBase() for easier maintainability: Requires: opnsense/core@2d45b78 * Update caddy_control.py - Change onerestart and other actions to restart Might fix: #3887 * Update Caddy.xml - Model Relation Fields to allow displaying multiple elements instead of only the description. This prevents duplicates being displayed without being able to know which entry is which. Possibly fixes: #3885 #3884 Also, since the descriptions are used by "internalModelUseSafeDelete", it's better to make them all required. * Update actions_caddy.conf - Add reload action The rc.d file communicates directly with the caddy admin endpoint, and can reload the configuration with the /var/run/caddy/caddy.sock without restarting the whole caddy process. * Update caddy_control.py - Add reload action The rc.d file communicates directly with the caddy admin endpoint, and can reload the configuration with the /var/run/caddy/caddy.sock without restarting the whole caddy process. * Update ServiceController.php - Turn off the ForceRestart Since caddy can use a reload instead * Add option to set a custom HTTP response code and message instead of using abort. This option can only be set globally in general settings. * Update pkg-descr - Add 1.5.4 * Update Makefile - Bump to 1.5.4 * Tether the HTTP repond logic to the Access List for more flexibility. * Update Caddy.xml - Change HTTPResponseCode and Message from general to accesslist * Add configuration framework for setting custom headers. WIP for #3881 * Update Caddy.xml - This shouldn't be here anymore... * Update Caddy.xml - Another mistake has sneaked in, fixed. * Update reverse_proxy.volt - Add new fields to bootgrid * Add template logic for header manipulation. WIP for #3881 * Update pkg-descr * Move selectpicker empty option to model in general.volt, using BlankDesc. This fixes the option IPv4+IPv6 not appearing in Dynamic DNS. * Update Caddyfile - Added some much needed comments the the most important sections and macros of the template. This should improve maintainability. * Update Caddyfile - Improve Comments, add Copyright header * Update Caddyfile - Improve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
Describe the bug
Domain under "Handlers" is referencing the Domain description rather than the actual domain name.
To Reproduce
Steps to reproduce the behavior:
example.com
as domain, andExample
as description.Example
.Example
rather thanexample.com
.Expected behavior
Under Reverse Domain Proxy and the Domain column, I would expect to see the Domain rather than the description.
Screenshots
Relevant log files
N/A
Additional context
This might just be by design. If so, feel free to close and I will just re-think about how I go about "Description". 😊
Environment
OPNsense
24.1.4-amd64
withos-caddy
version1.5.2
.The text was updated successfully, but these errors were encountered: