mail/postfix: Add support for configuring sender_canonical_maps #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFelix
changed the title
|
I had a short look and it looks good, will try to test tomorrow :) |
|
@mimugmail Ping :) |
|
Sorry, I just cloned your repo. Can you make sorting in Menu to number 48, it's not perfect but it looks better. And can you give me an example of from and to so I can play around? Also, do we need postmap for regexp type? |
|
I change the sorting number to 48. An example would be I read the postfix manuals again and it seems like it is definitely needed, so yes. |
|
We don‘t have a regex validator yet so be aware that free-text regex can break a config. |
|
Merged, thanks! |
|
I told you to stay offline during vacation! ;) Thx |
|
I‘m trying. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring postfix sender_canonical_maps with regexp expressions. This is needed when relaying mail over an external SMTP server that only allows sending with specific sender addresses. (e.g. only the address that was also used for authenticating with the external relay). This PR is based on the Address/virtual configuration in the postfix plugin and works mostly the same.