New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/freeradius: add Service-Type #1465
Conversation
<Required>N</Required> | ||
<multiple>Y</multiple> | ||
<OptionValues> | ||
<Option1 value="1">1</Option1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make these more user-friendly, but for now that is robust enough. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Display Text value with numeric value attached, like: THIS-SETTING (1) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I thought that this work might be a good start for new community members which insist on more descriptive values :)
Merged, thanks! |
Closes #1444
I made a multi_select field with Integer 1-19, so it's a mix of both discussed solutions.