Fixing smart widget #1848
Closed
Fixing smart widget #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for:
`Warning: Invalid argument supplied for foreach() in /usr/local/www/widgets/widgets/smart_status.widget.php on line 48`
For some reason, `configd_run('smart detailed list')` is returning `NULL`, this will at least handle that case.
|
Can you find out what this "some reason" is? Squelching a warning is not the best way to approach the underlying issue. |
|
Here, have an entire Twitter thread. Honestly, no idea. There is some deep rooted bug in OPNsense core somewhere. But this is the only widget that outright FAILS from whatever the underlying core is doing wrong, and causes error reports. |
|
Apparently the |
|
You may add the missing |
|
Hey, just an FYI: this bug STILL exists. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for:
Warning: Invalid argument supplied for foreach() in /usr/local/www/widgets/widgets/smart_status.widget.php on line 48For some reason,
configd_run('smart detailed list')is returningNULL, this will at least handle that case.