Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP mail/postfix: Add support for header_checks #1893

Closed
wants to merge 22 commits into from
Closed

WIP mail/postfix: Add support for header_checks #1893

wants to merge 22 commits into from

Conversation

Starkstromkonsument
Copy link
Contributor

@Starkstromkonsument Starkstromkonsument commented Jun 20, 2020 •
edited

@mimugmail
Copy link
Member

Headerchecks everywhere, also filenames, not HeaderChecks.

@Starkstromkonsument
Copy link
Contributor Author

@mimugmail thank you! That did the trick in the first place. Unfortunately I stumbled into the next problem. The form for adding/editing entries does not get the values defined in mail/postfix/src/opnsense/mvc/app/models/OPNsense/Postfix/Headerchecks.xml. The dropdown remains empty and the default value "1" for enabled is not being set:

grafik

Is there any way to get error messages from phalcon (I never worked with it before). I managed to turn on additional error messages for PHP

html_errors = on
error_reporting = E_ALL
display_startup_errors = on

but I don't get anything useful from phalcon.

@Starkstromkonsument Starkstromkonsument changed the title WIP: mail/postfix Add support for header_checks WIP mail/postfix: Add support for header_checks Jun 23, 2020
@mimugmail
Copy link
Member

F12 is your friend:

image

You are calling searchHeadercheck but your functions in HeaderchecksController.php are called searchHeaderchecksAction (missing s)

fraenki and others added 15 commits June 25, 2020 23:44
@fraenki @Starkstromkonsument
Merge pull request opnsense#1883 from MrRoundRobin/patch-1
6d8b338 
net/haproxy: add missing acl SNI regex text field
@fraenki @Starkstromkonsument
net/haproxy: add missing header, refs opnsense#1883
87d87cd
@fraenki @Starkstromkonsument
net/haproxy: bump version
c341722
@L1ghtn1ng @Starkstromkonsument
DNS/Dnscrypt-proxy remove discontinued feeds (opnsense#1886)
4bd5347
@marjohn56 @Starkstromkonsument
Correct colours in text-info and circle::before (opnsense#1892)
c3b5dfd 
Colours incorrect on firewall.
@fichtner @Starkstromkonsument
misc/theme-rebellion: bump revision
56ac2cc
@fichtner @Starkstromkonsument
README: sync
766edfa
@fichtner @Starkstromkonsument
dns/dyndns: style and naming
5aec179
@fichtner @Starkstromkonsument
dns/dyndns: new version
a64595d
@fichtner @Starkstromkonsument
net/shadowsocks: bump revision
4d849d6
@fichtner @Starkstromkonsument
security/intrusion-detection-content-snort-vrt: bump version
20f3493
@Starkstromkonsument
mail/postfix: Fix function calls in controllers/view/model for header…
344ab13 
…_checks
@Starkstromkonsument
mail/postfix: Open link to postfix docs for header_checks in a new tab
316cafd
@Starkstromkonsument
mail/postfix: Fix typo in templates for header_checks
0982896
@Starkstromkonsument
mail/postfix: Fix table class in view for header_checks
4ed6f8c 
The column of the multiselect-checkboxes was not shown correctly.
@Starkstromkonsument
Copy link
Contributor Author

Mmh. I guess I just messed this PR up by syncing my branch the wrong way ...

@Starkstromkonsument Starkstromkonsument deleted the postfix_header_checks branch June 25, 2020 22:02
@Starkstromkonsument
Copy link
Contributor Author

This PR has been replaced by #1897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postfix: header_checks for black / whitelisting
6 participants
@Starkstromkonsument @mimugmail @fraenki @L1ghtn1ng @marjohn56 @fichtner