Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www/nginx: quick fix for trusted CAs pem #2198

Merged
merged 1 commit into from Jan 31, 2021
Merged

Conversation

kulikov-a
Copy link
Member

Hi. just quick fix for troubles with trust_upstream_*.pem files after update to 1.20 with upstream tls verify enabled and trusted CAs selected

@fabianfrz fabianfrz self-requested a review January 20, 2021 21:15
@jkellerer
Copy link
Contributor

Had come up with exactly the same solution before finding this PR. Can confirm that it fixes the problem.

@kulikov-a
Copy link
Member Author

@fabianfrz
thanks for watching this!
may I add #1991 to this PR? a working SNI directives can be critical for upstream verification to work. so upstream can choose the right cert on request from nginx

@folfy
Copy link

folfy commented Jan 23, 2021

Does this fix the trust_upstream_* files not being put in place correctly?

root@gw:~ # ls -l /usr/local/etc/nginx/key/trust_upstream*
-rw------- 1 root wheel 3 Jan 23 22:07 /usr/local/etc/nginx/key/trust_upstream_5037b17e-fc0d-452a-9b59-da40823f7550.pem
-rw------- 1 root wheel 3 Jan 23 21:53 /usr/local/etc/nginx/key/trust_upstream_acc62566-fd6f-4488-8b88-a7022399cb56.pem
-rw------- 1 root wheel 3 Jan 23 22:05 /usr/local/etc/nginx/key/trust_upstream_d9229681-d046-4320-a741-276a3d7ae71e.pem

Size is 3 bytes, obviously not right, and saw some other users with that problem at the opnsense forum as well.

This broke my nginx-Server since I upgraded to OPNsense 20.7.8, had to disable upstream certificate verification for now to get it back up and running. Hope to see a fix being deployed soon :/

Copy link

@folfy folfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it as a patch to my local installation with two trusted certificates set up - working fine and fixes the bug preventing nginx from startup (nevermind my lazyness before to further investigate your PR)

@fichtner fichtner self-assigned this Jan 31, 2021
@fichtner fichtner merged commit fba4236 into opnsense:master Jan 31, 2021
@fichtner
Copy link
Member

Merged due to maintainer timeout, thank you! ❤️

@kulikov-a
Copy link
Member Author

@fichtner
thanks!!

@kulikov-a kulikov-a deleted the patch-1 branch January 31, 2021 12:57
andreas-stuerz pushed a commit to andreas-stuerz/plugins that referenced this pull request Feb 2, 2021
windgmbh pushed a commit to windgmbh/opnsense-plugins that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants