Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns/dnscrypt-proxy: fixed "disabled_server_names" #2788

Merged
merged 1 commit into from Jan 31, 2022

Conversation

Karlson2k
Copy link
Contributor

@Karlson2k Karlson2k commented Jan 30, 2022

Fixed function of "Disabled Servers List" when more than one server specified in the list.

@fichtner
Copy link
Member

How does the generated output differ?

@Karlson2k
Copy link
Contributor Author

Before this patch:

disabled_server_names = ['name1,name2,name3']

After this patch:

disabled_server_names = ['name1','name2','name3']

@fichtner fichtner self-assigned this Jan 30, 2022
@fichtner
Copy link
Member

@Karlson2k ok makes sense. jinja doesn't offer anything quite less obscure than this so we have to go with this solution.. just a bit hard to read (and GitHub markup for toml isn't helping here either). waiting for @mimugmail to wake up and nod

@Karlson2k
Copy link
Contributor Author

Karlson2k commented Jan 31, 2022

It was actually copied from server_names a few lines above. The code with this patch should be consistent at least.

Copy link
Member

@mimugmail mimugmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do you want to add a changelog to pkg-descr? Version bump not needed as I also pushed a fix

@Karlson2k
Copy link
Contributor Author

@mimugmail will do it in minutes.

Fixed function of "Disabled Servers List" when more than one server
specified in the list.
@Karlson2k
Copy link
Contributor Author

@mimugmail Done.

@fichtner fichtner merged commit 4227a01 into opnsense:master Jan 31, 2022
@fichtner
Copy link
Member

merged, thank you!

AdSchellevis pushed a commit that referenced this pull request Feb 2, 2022
Fixed function of "Disabled Servers List" when more than one server
specified in the list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants