Add Digitalocean ddns support #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Jan 6, 2024
| @@ -93,6 +93,9 @@ server=www.ovh.com, \ | |||
| protocol={{account.service}}, \ | |||
| apikey={{account.username}}, \ | |||
| secretapikey={{account.password}}, \ | |||
| {% elif account.service == 'digitalocean' %} | |||
There was a problem hiding this comment.
can you try to retain alphabetical ordering here? it's already a bit difficult to follow this part of the template with the duplication (ideally it's the same as cloudflare or others).
There was a problem hiding this comment.
you mean something like that?
diff --git a/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf b/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf
index 6c2cf332..333d478a 100644
--- a/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf
+++ b/dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf
@@ -36,7 +36,7 @@ use=cmd, cmd="/usr/local/opnsense/scripts/ddclient/checkip -t {{account.force_ss
{% if account.service == 'custom' %}
protocol={{account.protocol}}, \
server={{account.server}}, \
-{% elif account.service == 'cloudflare' %}
+{% elif account.service in ['cloudflare', 'digitalocean'] %}
protocol={{account.service}}, \
zone={{account.zone}}, \
{% elif account.service == 'cloudns' %}
@@ -93,9 +93,6 @@ server=www.ovh.com, \
protocol={{account.service}}, \
apikey={{account.username}}, \
secretapikey={{account.password}}, \
-{% elif account.service == 'digitalocean' %}
-protocol={{account.service}}, \
-zone={{account.zone}}, \
{% else %}
protocol={{account.service}}, \
{% endif %}
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Digitalocean ddns support