Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/acme-client: restart www/caddy automation added #3877

Closed
wants to merge 2 commits into from

Conversation

Monviech
Copy link
Sponsor Member

I have added an automation to restart Caddy when the Acme Client certificates are used.

Hope it's correct this way. Thank you ^^

@fraenki
Copy link
Member

fraenki commented Mar 31, 2024

There's an alternative approach available: add a description to the configd actions of www/caddy:
https://github.com/opnsense/plugins/blob/master/www/caddy/src/opnsense/service/conf/actions.d/actions_caddy.conf#L13-L17

Then they would be automatically available in ACME client:
Automations -> Add -> Run Command: System of Plugin Command

However, if you prefer this PR, I'd have no objections to merge it.

@fraenki fraenki self-assigned this Mar 31, 2024
@Monviech
Copy link
Sponsor Member Author

Monviech commented Apr 1, 2024

The description sounds better maintainable:
https://github.com/Monviech/opnsense-plugins/blob/74f9521c99ae211851da18bab7edc3fa8cf1bda9/www/caddy/src/opnsense/service/conf/actions.d/actions_caddy.conf#L18

Thanks for explaining it. Since its an edge case to restart Caddy with the ACME client since by default it does its own Let's Encrypt, I don't have any problem with it that it's more hidden.

@Monviech Monviech closed this Apr 1, 2024
@Monviech Monviech deleted the acme-plugin-restart-caddy branch April 3, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants