www/caddy: template fix tls_server_name option #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is allowed for these TLS Options to appear more freely inside the transport_http blocks without producing an invalid configuration. For example, "tls_server_name" is not required to appear together with "tls"
Ensure that when "NTLM" is chosen, TLS has to be enabled at the same time.
Monviech
changed the title
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is valid to use the
tls_server_nameoption, and most other options, inside atransport_httportransport_ntlmblock without having an invalid configuration. For some configurations, it seems to be required to only havetls_server_nameinsidetransport_http.At the same time, a constraint was added to
tlsandntlmbecause they depend on each other, also in the template.Fixes: https://forum.opnsense.org/index.php?topic=39951.msg197303#msg197303