www/caddy: Allow bind to non standard ports #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tandard http and https ports.
|
@AdSchellevis If you have time, I would love some feedback on this idea. Offering bind to the default loopback interface should be safe, right? EDIT: Wait I totally forgot the outgoing traffic... The reverse_proxy could not initiate connections to the backend when bound to the loopback interface. It would need some source NAT magic and thats dumb. I probably scrap the interface binding again and just offer the custom ports. Offering binding to IP addresses is an even more broken concept for a reverse proxy than I initally even thought... EDIT2: Removed. |
…ng default_bind option.
Monviech
changed the title
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4065
Adds following options:
http_port: https://caddyserver.com/docs/caddyfile/options#http-porthttps_port: https://caddyserver.com/docs/caddyfile/options#https-porthttp_portandhttps_portcan be chosen freely. The validation catches errors when there are conflicts with the WebGUI ports.This should satisfy advanced usecases without causing regressions.