UDPBroadcastrelay UI fix for 24.7 #4107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI interface worked fine pre 24.7 but something has broken it. Changes applied fix the issue
Update udpbroadcastrealy controller interface
fichtner
reviewed
Jul 23, 2024
| @@ -44,10 +43,6 @@ class ServiceController extends ApiMutableModelControllerBase | |||
|
|
|||
| public function statusAction($uuid) | |||
| { | |||
| $result = array("result" => "failed", "function" => "status"); | |||
fichtner
reviewed
Jul 23, 2024
| @@ -126,10 +121,6 @@ public function restartAction($uuid) | |||
| */ | |||
| public function configAction() | |||
| { | |||
| $result = array("result" => "failed", "function" => "config"); | |||
fichtner
reviewed
Jul 23, 2024
| @@ -31,7 +31,6 @@ | |||
| use OPNsense\Base\ApiMutableModelControllerBase; | |||
| use OPNsense\UDPBroadcastRelay\UDPBroadcastRelay; | |||
| use OPNsense\Core\Backend; | |||
|
|
|||
There was a problem hiding this comment.
if you can bring back this spacer line also ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI was causing errors when running under 24.7, this issue was not present in 24.1 and earlier versions. Not sure what's causing it but removing the following:
fixes the issue.