sysutils/smart: fix coloring for themes; "s/\t/ /g"; cleanup php #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Nov 5, 2018
| Copyright (C) 2014 Deciso B.V. | ||
| Copyright 2012 mkirbst @ pfSense Forum | ||
| All rights reserved. | ||
| Copyright (C) 2018 Fabian Franz |
There was a problem hiding this comment.
ok if you want to reformat, but use " * " indent
There was a problem hiding this comment.
okay, I have to reject this: checked file history and reformatting does not warrant copyright even if it is done cleverly. no substantial changes in this particular file of the code implementation.
fichtner
reviewed
Nov 5, 2018
| <td class="listr" style="text-align:center"><span style="background-color:<?php echo $color; ?>"> <?php echo $dev_state_translated ?> </span></td> | ||
| </tr> | ||
| <tr> | ||
| <td class="listlr"><?= $dev ?></td> |
There was a problem hiding this comment.
listlr and listr can be removed
|
should be done |
fichtner
reviewed
Nov 5, 2018
fichtner
reviewed
Nov 5, 2018
fichtner
approved these changes
Nov 5, 2018
|
Merged, thanks! |
fichtner
pushed a commit
that referenced
this pull request
Nov 6, 2018
(cherry picked from commit f0d2a2e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.