Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/haproxy: more features for release 2.10 #970

Merged
merged 5 commits into from Nov 11, 2018

Conversation

fraenki
Copy link
Member

@fraenki fraenki commented Nov 11, 2018

full changelog added to #960

@fraenki fraenki added the feature Adding new functionality label Nov 11, 2018
@fraenki fraenki self-assigned this Nov 11, 2018
@fraenki
Copy link
Member Author

fraenki commented Nov 11, 2018

Migration M2_6_0 tested and working as expected:

Installing os-haproxy-devel-2.10...
Extracting os-haproxy-devel-2.10: 100%
Stopping configd...done
Starting configd.
Migrated OPNsense\HAProxy\HAProxy from 2.3.0 to 2.6.0
Reloading plugin configuration
Configuring system logging...done.
Reloading template OPNsense/HAProxy: OK

Copy link
Member

@fabianfrz fabianfrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some findings

@fraenki
Copy link
Member Author

fraenki commented Nov 11, 2018

Guide: Enable HTTP Basic Auth in HAProxy

1. Setup a Condition

HAProxy will match username/password from client against the specified list of users/groups:

auth001

2. Setup a Rule

HAProxy will send auth request if client username/password does not match:

auth002

3. Add Rule to Public Service (or Backend Pool)

This will enable HTTP Basic Auth for a Public Service or Backend Pool:

auth003

@fraenki
Copy link
Member Author

fraenki commented Nov 11, 2018

@fabianfrz Thanks for your review!

@fabianfrz
Copy link
Member

@fraenki you may want to migrate some code to the *Base methods, to reduce the size of the controller.
It makes most actions one liners except some special ones which do need a more specific behaviour.

@fraenki
Copy link
Member Author

fraenki commented Nov 11, 2018

@fabianfrz I'll consider this for a future release, the changeset is already quite large for a minor release.

@fraenki fraenki changed the title [WIP] net/haproxy: new release [WIP] net/haproxy: more features for release 2.10 Nov 11, 2018
@fraenki fraenki changed the title [WIP] net/haproxy: more features for release 2.10 net/haproxy: more features for release 2.10 Nov 11, 2018
@fraenki fraenki merged commit 70d8966 into opnsense:master Nov 11, 2018
@fraenki
Copy link
Member Author

fraenki commented Nov 11, 2018

@fichtner Please merge for OPNsense 18.7.8.

@fichtner
Copy link
Member

will do. do you ack 0e264d4 as well?

@fraenki
Copy link
Member Author

fraenki commented Nov 12, 2018

@fichtner Haven't tested your changes yet, but I'll do later today. So yes, ACK :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

Successfully merging this pull request may close these issues.

None yet

3 participants