New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/haproxy: more features for release 2.10 #970
Conversation
Migration M2_6_0 tested and working as expected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some findings
net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/forms/dialogBackend.xml
Outdated
Show resolved
Hide resolved
net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/forms/dialogUser.xml
Outdated
Show resolved
Hide resolved
Guide: Enable HTTP Basic Auth in HAProxy1. Setup a ConditionHAProxy will match username/password from client against the specified list of users/groups: 2. Setup a RuleHAProxy will send auth request if client username/password does not match: 3. Add Rule to Public Service (or Backend Pool)This will enable HTTP Basic Auth for a Public Service or Backend Pool: |
@fabianfrz Thanks for your review! |
@fraenki you may want to migrate some code to the *Base methods, to reduce the size of the controller. |
@fabianfrz I'll consider this for a future release, the changeset is already quite large for a minor release. |
@fichtner Please merge for OPNsense 18.7.8. |
will do. do you ack 0e264d4 as well? |
@fichtner Haven't tested your changes yet, but I'll do later today. So yes, ACK :) |
full changelog added to #960