Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] Add new foundations icons #48

Merged
merged 10 commits into from
Oct 9, 2022

Conversation

elenagarbo
Copy link
Contributor

Tarea: [DT 2.6.0] Añadir nuevos iconos a Design Tokens
Figma iconos

Qué se hizo

Dentro de la carpeta de assets/icons/lib se han añadido los nuevos iconos que marca figma:

  • Iconos answered y not-answered, se mantiene el stroke: #ffffff para que se vea la forma correcta
    Captura de pantalla de 2022-10-05 12-57-01

  • Icono filter ha sido actualizado por el nuevo:

Antes Después
Captura de pantalla de 2022-10-05 12-57-50 Captura de pantalla de 2022-10-05 12-58-05
  • Icono save se le añaden currentColor en todos los path.

Queda pendiente

Se ha dejado un comentario en Figma para diseño ya que faltan algunos iconos en el Foundations (smile, trending_up, printer, popover-arrow-down y popover-arrow-up)

Una vez que este correcta la PR se han creado tareas para utilizar los iconos de la DT:
Ecommerce https://kanbanflow.com/t/ov2BzFQ4
Aula https://kanbanflow.com/t/ov2BzFQ4
LMS https://kanbanflow.com/t/qwQo4FiS

@elenagarbo elenagarbo changed the title Feature/add new foundations icons [TS] Add new foundations icons Oct 5, 2022
@dlorenzonespereira dlorenzonespereira merged commit 32aa640 into main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants