-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add button to complete missing URL and legal information #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mstykow
force-pushed
the
feat-button-to-complete-missing-url-legal
branch
from
December 22, 2023 17:01
4a7db91
to
6348d48
Compare
I'm using a toaster now so that the hiding is no longer necessary. |
mstykow
force-pushed
the
feat-button-to-complete-missing-url-legal
branch
from
January 4, 2024 11:27
6348d48
to
38d1430
Compare
First of all, this feature is really awesome!
|
mstykow
force-pushed
the
feat-button-to-complete-missing-url-legal
branch
2 times, most recently
from
January 5, 2024 11:08
0af838c
to
bc737c2
Compare
antonbauhofer
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
mstykow
force-pushed
the
feat-button-to-complete-missing-url-legal
branch
from
January 5, 2024 15:17
bc737c2
to
2696b2f
Compare
- add magic wand button in URL input field - show success or error toasts when user clicks magic wand button - also show toasts on copy/paste clipboard buttons - fix tryit function to wait for promise - throw for error status by default to avoid needing to perform `response.ok` checks closes #2445 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
feat-button-to-complete-missing-url-legal
branch
from
January 5, 2024 15:26
2696b2f
to
513a4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
response.ok
checksContext and reason for change
Closes #2445.
How can the changes be tested
Select a signal with only partial information and try to fill the missing information with the new button. Also note that the button should disappear after the attempt, whether successful or not.