chore: remove axios dependency #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstykow
force-pushed
the
chore-remove-axios-dependency
branch
from
a7ac154
to
bc132c1
Compare
mstykow
force-pushed
the
chore-remove-axios-dependency
branch
from
bc132c1
to
15bf088
Compare
- replace last remaining axios usage with fetch API - simplify logic and tests for UpdateAppPopup - extract common spinner Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
chore-remove-axios-dependency
branch
from
15bf088
to
59396a0
Compare
alexzurbonsen
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
There is no need for a library to do our fetching since we can use the
fetchAPI. Some parts of the app already use thefetchAPI and this PR makes sure that all remaining requests also do so now.How can the changes be tested
Check that the "update app popup" still works as expected, i.e., shows message to download new release.