fix: honor non-editable attribution/signal state #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribution - when viewing a non-editable signal or attribution it is not necessary to load any suggestions - the input field was already correctly disabled before Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
… attribution/signal is editable Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
changed the title
mstykow
deleted the
fix-disable-autocomplete-network-requests-when-not-editable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
Avoid unnecessary background requests and honor non-editable state.
How can the changes be tested
While in audit view, open the dev tools network tab. Then select once an attribution that is editable and then one that is not (for example a signal). Notice that only the editable attribution should trigger network requests.
Find a signal which is marked as "needs follow-up" and note that you cannot remove the tag (previously possible on main).