Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not highlight missing attribution version #2532

Merged
merged 1 commit into from Jan 25, 2024

Conversation

mstykow
Copy link
Collaborator

@mstykow mstykow commented Jan 25, 2024

Summary of changes

  • remove "version" from the list of required attributes

Context and reason for change

closes #2527

How can the changes be tested

Create an attribution with all required fields, except version. Notice that the attribution no longer has the yellow tooth on the package card and also that the version input field is not highlighted in yellow in attribution view.

- remove "version" from the list of required attributes

closes #2527

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
@mstykow mstykow force-pushed the feat-do-not-highlight-missing-versions branch from 7814f6a to 3fc7289 Compare January 25, 2024 09:57
@alexzurbonsen alexzurbonsen self-assigned this Jan 25, 2024
@mstykow mstykow merged commit 3d8d51e into main Jan 25, 2024
5 checks passed
@mstykow mstykow deleted the feat-do-not-highlight-missing-versions branch January 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not highlight missing attribution versions
2 participants