Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating attribution with original signal or suggestion #2552

Merged
merged 1 commit into from Jan 31, 2024
Merged

fix: updating attribution with original signal or suggestion #2552

merged 1 commit into from Jan 31, 2024

Conversation

mstykow
Copy link
Collaborator

@mstykow mstykow commented Jan 31, 2024

Summary of changes

  • attributes "id", "preSelected" should not be used when updating an attribution via an original signal or suggestion
  • also ensure multiple comments are dropped

How can the changes be tested

  1. Modify a previously preferred and pre-selected attribution, save the changes, and then click on the chip to revert to the original state.
  2. Pick a suggestion from an autocomplete via the "+" button and notice that id, pre-selected do not change while an suggested signal that had multiple comments drops these comments.

@mstykow
fix: updating attribution with original signal or suggestion
ac11ece 
- attributes "id", "preSelected" should not be used when updating an attribution via an original signal or suggestion
- also ensure multiple comments are dropped

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
alexzurbonsen
alexzurbonsen approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@alexzurbonsen alexzurbonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@mstykow mstykow merged commit cb8c737 into main Jan 31, 2024
5 checks passed
@mstykow mstykow deleted the fix-updating-attribution-with-original-signal-or-suggestion branch January 31, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzurbonsen alexzurbonsen alexzurbonsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstykow @alexzurbonsen