Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autocomplete end-icon click opens popover #2573

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mstykow
Copy link
Collaborator

@mstykow mstykow commented Feb 15, 2024

Summary of changes

  • stop propagation of mouse-down and click events on end-adornment container

How can the changes be tested

To reproduce issue on main:

  1. Open a file that offers suggestions for repository URLs when you click into the "repository URL" input field of the attribution details.
  2. Click on the "magic wand" or "open URL in browser" icon buttons at the end of the input field.
  3. Notice that the suggestions popover opens.

Expected: popover should remain closed and only open when the underlying input field is clicked.

@alexzurbonsen alexzurbonsen self-assigned this Feb 15, 2024
- stop propagation of mouse-down and click events on end-adornment container

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
@mstykow mstykow force-pushed the fix-autocomplete-end-icon-click branch from 9c005ad to 573a2af Compare February 16, 2024 07:58
@mstykow mstykow merged commit 928e26b into main Feb 16, 2024
5 checks passed
@mstykow mstykow deleted the fix-autocomplete-end-icon-click branch February 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants