feat: add keyboard navigation for resource tree #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstykow
force-pushed
the
feat-list-keyboard-navigation
branch
from
109cd84
to
b95ffda
Compare
mstykow
force-pushed
the
feat-tree-keyboard-navigation
branch
from
3be3c17
to
c65d5e0
Compare
mstykow
force-pushed
the
feat-list-keyboard-navigation
branch
from
b95ffda
to
18d42f1
Compare
mstykow
force-pushed
the
feat-tree-keyboard-navigation
branch
from
c65d5e0
to
6deb431
Compare
MarkusObendrauf
force-pushed
the
feat-tree-keyboard-navigation
branch
3 times, most recently
from
a8ded4b
to
05aa69a
Compare
mstykow
force-pushed
the
feat-list-keyboard-navigation
branch
2 times, most recently
from
29cd131
to
50a0462
Compare
- keep track of focused ID instead of focused index in Virtuoso - add focus state for tree nodes and define keyboard actions closes #2572 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com> Signed-off-by: Markus Obendrauf <markus.obendrauf@tngtech.com>
mstykow
force-pushed
the
feat-tree-keyboard-navigation
branch
from
05aa69a
to
91bf5fa
Compare
mstykow
commented
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
closes #2572
How can the changes be tested
Navigate the resource browser up and down and left and right and check that focus behaves as expected.