feat: filter for modified previously preferred attributions V2 #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstykow
force-pushed
the
feat-filter-modified-preferred-v2
branch
from
5f0e539
to
8bc06a5
Compare
mstykow
commented
Mar 12, 2024
mstykow
force-pushed
the
feat-filter-modified-preferred-v2
branch
from
8bc06a5
to
5ced33d
Compare
- introduce new ephemeral attributes to keep track of ID, source, and previously-preferred of original attribution - introduce filter and package card icon for modified-previously-preferred attributions closes #2508 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
feat-filter-modified-preferred-v2
branch
from
8195aa3
to
132fe94
Compare
alexzurbonsen
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
closes #2508
How can the changes be tested
Check that filtering for modified previously preferred attributions works as expected as you add/remove/edit previously-preferred attributions.
Also check that original sources are still correctly displayed.