chore: dynamically enable menu options #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzurbonsen
commented
Apr 23, 2024
| @@ -176,6 +243,8 @@ export async function createMenu(mainWindow: BrowserWindow): Promise<Menu> { | |||
| ); | |||
| } | |||
| }, | |||
| id: MENU_ITEMS.projectStatistics.id, | |||
| enabled: false, | |||
| }, | |||
| { | |||
| icon: getIconBasedOnTheme( | |||
There was a problem hiding this comment.
I was not sure about this option: 'Set Path to Sources'. Disabled it as well?
leslielazzarino
approved these changes
Apr 23, 2024
mstykow
reviewed
Apr 23, 2024
src/ElectronBackend/main/menu.ts
Outdated
|
|
||
| type Item = { label: string; id: string }; | ||
|
|
||
| const MENU_ITEMS: Record<(typeof INITIALLY_DISABLED_MENU_ITEMS)[number], Item> = |
There was a problem hiding this comment.
i find that calling this MENU_ITEMS is misleading, since this is only the disabled menu items.
There was a problem hiding this comment.
Right, I will come up with something else.
alexzurbonsen
force-pushed
the
dynamically-enable-menu-options
branch
from
d31767d
to
2be9cac
Compare
Signed-off-by: alexzurbonsen <alexander.zur.bonsen@tngtech.com>
alexzurbonsen
force-pushed
the
dynamically-enable-menu-options
branch
from
2be9cac
to
dbe5b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR deactivates some menu options initially and activates them once a file is opened.
Ideally, I wanted to disable the entire
Editmenu, but that does not come with nice UX. Instead I disabled individual options. The ones that come with a role, likecutandcopycannot be disabled in the same way. I left them as is.I would have also liked to disable the
Exportsubmenu in theFilemenu. But if I do that I can't enable it in the same way as individual items. As an easy solution I just disabled the submenu items instead.Context and reason for change
Closes #2411
How can the changes be tested
Manually check that options are disabled and will be enabled once a file is opened.