Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make progress bar consistent in new lesson player mocks. #90

Closed
3 tasks
seanlip opened this issue Jul 30, 2023 · 3 comments
Closed
3 tasks

Make progress bar consistent in new lesson player mocks. #90

seanlip opened this issue Jul 30, 2023 · 3 comments
Assignees

Comments

@seanlip
Copy link
Member

seanlip commented Jul 30, 2023

Platform
Oppia Web

Describe the request

@ningz2 mentions in oppia/oppia#18247:

In the Lesson Player project, it seems like the progress bar on the "Exit" pop-up window is not consistent with the graphic on Checkpoint project, so I'd like to coordinate on this point.

The aim of this issue is to do the necessary coordination and make any changes to the Figma files so that the design team as a whole has a single idea of what they plan to do here.

Context for the request

This was brought up as part of a discussion in oppia/oppia#18247. It is not a technical issue so I am filing it here.

Information about deadlines/priorities

This should be sorted out before any development work happens on Julia's lesson player mocks or the checkpoints mocks (if not integrated with Julia's).

DESIGN APPROVAL CHECKLIST -- DO NOT EDIT.

  • UX Design approved
  • UX Writing approved
  • Product approved

For a design project to be completed, it needs approval from UXD, UXW and PM. Please tag the following reviewers when your project is ready (it's enough to have one signoff from each of UXD, UXW and PM):

@juliafalarini
Copy link

juliafalarini commented Aug 1, 2023

If it's only about adding the phone number and email to the dialog box, I can do that very quickly. If there is anything else that needs to be reviewed, please clarify @ningz2 @seanlip. Thanks!

@seanlip
Copy link
Member Author

seanlip commented Aug 2, 2023

Thanks @juliafalarini. @ningz2 -- I'm filing this issue based on a comment you left on the other one. Could you please clarify what is required in order for this issue to be resolved?

Thanks!

@seanlip
Copy link
Member Author

seanlip commented Aug 4, 2023

Per @ningz2 and @juliafalarini -- they'll file another issue replacing this one with more details. Closing this one in the meantime.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants