Skip to content

Commit

Permalink
Fix #66: Cursor change to pointer when hover over video control butto…
Browse files Browse the repository at this point in the history
…ns (#71)

* Cursor change to pointer when hover over video control buuttons

* Fix indentation for video attributes
  • Loading branch information
hoangviet1993 authored and seanlip committed Sep 19, 2018
1 parent 05e69e6 commit 0ced97f
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .htmllintrc
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"tag-self-close": false,
"doctype-first": false,
"doctype-html5": false,
"attr-name-style": "dash",
"attr-name-style": false,
"attr-name-ignore-regex": false,
"attr-no-dup": true,
"attr-no-unsafe-char": false,
Expand Down
8 changes: 8 additions & 0 deletions static/assets/css/stylesheet.css
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ video {
vertical-align: baseline;
}

video::-webkit-media-controls-fullscreen-button,
video::-webkit-media-controls-overlay-play-button,
video::-webkit-media-controls-timeline,
video::-webkit-media-controls-mute-button,
video::-webkit-media-controls-toggle-closed-captions-button,
video::-webkit-media-controls-volume-slider {
cursor: pointer;
}

/* HTML5 display-role reset for older browsers */

Expand Down
5 changes: 3 additions & 2 deletions static/pages/home/home.html
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ <h1>
<div class="macbook">
<div class="screen">
<div class="viewport">
<video controls class="home-page-interactions-video">
<video controls controlsList="nodownload"
class="home-page-interactions-video">
<source src="/assets/videos/Interactions_video.mp4"
type="video/mp4">
Your browser does not support the video tag.
Expand Down Expand Up @@ -129,7 +130,7 @@ <h3 class="md-display-1 home-page-content-title">
<div class="macbook">
<div class="screen">
<div class="viewport" controls>
<video controls
<video controls controlsList="nodownload"
class="home-page-interactions-video">
<source src="/assets/videos/Interactions_video.mp4"
type="video/mp4">
Expand Down

0 comments on commit 0ced97f

Please sign in to comment.