Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding build files #9

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Adding build files #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3af7ec
Added build files
HardikGoyal2003 Feb 26, 2024
b676ebf
Added PR template and updated build instruction
HardikGoyal2003 Feb 27, 2024
38a7757
Updating the PR template
HardikGoyal2003 Feb 28, 2024
322e192
Updating the PR template
HardikGoyal2003 Feb 28, 2024
8d2e8a6
Typo correction
HardikGoyal2003 Mar 1, 2024
7a25698
Correction in PR template
HardikGoyal2003 Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ If there is no corresponding issue number, fill in N/A where it says [fill_in_nu
## Essential Checklist

- [ ] The **PR title** starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
- [ ] I have followed the build process and error check mentioned in the [readme file](https://github.com/oppia/guppy/blob/master/README.md).
- [ ] I have followed the build process and verifying your changes mentioned in the [readme file](https://github.com/oppia/guppy/blob/master/README.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed the build process and "verifying your changes" section mentioned in the ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

- [ ] I have followed the [instructions for making a code change](https://github.com/oppia/oppia/wiki/Make-a-pull-request).
- [ ] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
- [ ] The linter/Karma presubmit checks pass on my local machine, and my PR follows the [coding style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide)).
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ After making the changes in the Oppia's guppy fork, follow the below steps:
```
$ npm test
```
## Error check
## Verifying your changes
After adding build changes on the local guppy directory, follow the below steps to ensure the changes made are correct.
* Go to ``oppia/package.json`` file on local system.
* Find the line with ``guppy-dev``, and change the path to your local guppy fork ([Example](https://github.com/oppia/guppy/pull/9#issuecomment-1967417760)).
* Now, restart the sever and manually test the guppy supported interaction thoroughly to ensure that the changes you made are not breaking any part of the code.
* Now, restart the server and manually test the guppy supported interaction thoroughly to ensure that the changes you made are not breaking any part of the code.
* After that you are all set to make a PR!

## License
Expand Down