Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce custom type - OppiaImage that renders both Bitmaps and Svgs #1039

Open
veena14cs opened this issue May 5, 2020 · 1 comment
Open

Introduce custom type - OppiaImage that renders both Bitmaps and Svgs #1039

veena14cs opened this issue May 5, 2020 · 1 comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

veena14cs commented May 5, 2020 •
edited

This issue tracks custom type representation of an OppiaImage (make use of Kotlin's sealed classes) we want one subtype of OppiaImage that corresponds to bitmaps, and a second for SVGs as per the comment in #1020 . To simplify rendering of images, as of now the implementation is separate for bitmap and svg image.
@veena14cs veena14cs changed the title Introduce common custom type - OppiaImage that renders both Bitmaps and Svgs Introduce custom type - OppiaImage that renders both Bitmaps and Svgs May 5, 2020
@veena14cs veena14cs added Priority: Nice-to-have This work item is nice to have for its milestone. Type: Improvement labels May 5, 2020
@veena14cs veena14cs mentioned this issue May 5, 2020
Merged
@BenHenning BenHenning added this to the Backlog milestone Jun 23, 2020
@BenHenning BenHenning mentioned this issue Aug 5, 2020
Merged
8 tasks
@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@prayutsu prayutsu mentioned this issue Oct 15, 2020
Closed
8 tasks
@BenHenning BenHenning removed the Hacktoberfest This is a suggested Hacktoberfest issue. label Dec 3, 2020
@prayutsu
Copy link
Contributor

Unassigning myself

@prayutsu prayutsu removed their assignment Dec 19, 2020
@Broppia Broppia added issue_type_feature Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added issue_type_infrastructure Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed good second issue labels Sep 14, 2022
@BenHenning BenHenning removed this from the Backlog milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
@seanlip seanlip removed the Priority: Nice-to-have This work item is nice to have for its milestone. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Break-down Indicates that an issue is too large and should be broken into smaller chunks. Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1039: Introduce custom type oppia image [WIP] prayutsu/oppia-android
9 participants
@MohamedMedhat1998 @seanlip @BenHenning @veena14cs @anandwana001 @aggarwalpulkit596 @prayutsu @MohitGupta121 @Broppia