Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Changes to proto and test cases in domain layer #1476

Closed
rt4914 opened this issue Jul 16, 2020 · 1 comment
Closed

Introduce Changes to proto and test cases in domain layer #1476

rt4914 opened this issue Jul 16, 2020 · 1 comment
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 16, 2020

Once #1460 is merged we will need to update the proto to support additional attributes specially thumbnail_bg_color and other general attributes. Also, add tests cases for the same.
@rt4914 rt4914 self-assigned this Jul 16, 2020
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Status: Not started Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels Jul 16, 2020
@rt4914 rt4914 added this to the Alpha milestone Jul 16, 2020
@rt4914 rt4914 changed the title Introduce Changes to proto and test cases in domain layer [Blocked on #1460] Introduce Changes to proto and test cases in domain layer Jul 30, 2020
@rt4914 rt4914 mentioned this issue Jul 30, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Jul 30, 2020
@rt4914
Fix part of #1476: Lesson Thumbnail now supports (#1544)
173bf90 
* Updated recommended story implementation

* Updated recommended stories implementation

* Topic thumbnail generalised code

* Story thumbnail generalisation

* Subtopic thumbnail generalisation

* Removed skill thumbnail

* Exploration thumbnail generalised

* Nit changes

* Updated protos

* Nit proto change

* Added ktlint comments inline

* Updated failing test cases

* Nit change

Co-authored-by: Rajat Talesra <talesra@google.com>
@rt4914
Copy link
Contributor Author

rt4914 commented Aug 7, 2020

Closed via #1554 #1544

@rt4914 rt4914 closed this as completed Aug 7, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
2 participants
@rt4914 @BenHenning