Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rendering of Svg images from server[DO NOT MERGE]. #1015

Closed
wants to merge 6 commits into from

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Apr 24, 2020

Explanation

This PR implements rendering of svg images from server.

For Testing

  1. In GlideImageLoader on line number 49 replace model with url "https://cdn.shopify.com/s/files/1/0496/1029/files/Freesample.svg"
  2. In assets folder goto fraction_exploration0.json file. Search for image name img_20180121_113315_pqwqhf863w_height_565_width_343 and replace png to svg.

@veena14cs veena14cs changed the title Fix: Rendering of Svg images from server. Fix: Rendering of Svg images from server[DO NOT MERGE]. Apr 24, 2020
@veena14cs
Copy link
Contributor Author

Duplicate of this pr is created here #1019

@veena14cs veena14cs closed this Apr 24, 2020
@veena14cs veena14cs deleted the load-svg branch April 24, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants