Fix: Rendering of Svg images from server[DO NOT MERGE]. #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veena14cs
changed the title
veena14cs
assigned nikitamarysolomanpvt and rt4914 and unassigned rt4914 and nikitamarysolomanpvt
|
Duplicate of this pr is created here #1019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR implements rendering of svg images from server.
For Testing
GlideImageLoaderon line number 49 replace model with url "https://cdn.shopify.com/s/files/1/0496/1029/files/Freesample.svg"fraction_exploration0.jsonfile. Search for image nameimg_20180121_113315_pqwqhf863w_height_565_width_343and replace png to svg.