Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1547: Change 'correct_answer' field in GaeSolution.kt to 'Any?' #1548

Closed
wants to merge 154 commits into from
Closed

Fix #1547: Change 'correct_answer' field in GaeSolution.kt to 'Any?' #1548

wants to merge 154 commits into from

Conversation

miaboloix
Copy link
Contributor

@miaboloix miaboloix commented Jul 30, 2020 •
edited

Explanation

Fix #1547: Change 'correct_answer' field in GaeSolution.kt to 'Any?'

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@miaboloix
Working on having one module build with bazel
d68f0a9
@miaboloix
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
3115352 
… develop
@miaboloix
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
897bf6d 
… develop
@miaboloix
Created initial app-level WORKSPACE file
37a13f8
@miaboloix
Added proto_library rule to build model app module
f522846
@miaboloix
Added newline at end of WORKSPACE file
372deae
@miaboloix
Created macro to process proto files
5c0b6f5
@miaboloix
Both Bazel and Gradle now build /model successfully
9408e27
@miaboloix
Fixed typo in BUILD
7d44fea
@miaboloix
Added missing end of file empty lines
5c44743
@miaboloix
Added Robolectric dependencies and general build rule
0204754
@miaboloix
Source files building in both systems - added a TODO for test files
cb11a09
@miaboloix
Turned two kt_android_library rules into one
a8b989f
@miaboloix
Added dependencies for test files
ad2cb36
@miaboloix
Created kt_android_library rule for source files
379990e
@miaboloix
Add TODO for android_local_test rule
6d9f244
@miaboloix
Added a test manifest for android_local_test()
c45c72e
@miaboloix
Added Firebase dependencies and git_repository for tools_android
04d2281
@miaboloix
Refactored google-services.json, imported new dependencies
f486024
@miaboloix
Fixed Bens nits
fa16eb4
@miaboloix
Fixed space in WORKSPACE comment
5d31b5c
@miaboloix
Got a demo test working in both Java and Kotlin
3f9ed65
@miaboloix
Added rules_java dependencies for protocol buffers
1c982a9
@miaboloix
Added java_proto_library rules, each proto file now has its own rule
a7346e1
@miaboloix
Remove unnecessary srcs attribute for android_library
6fc021b
@miaboloix
Rename bzl file macro
b3d55e8
@miaboloix
Added Robolectric dependencies and general build rule
7030c83
@miaboloix
Source files building in both systems - added a TODO for test files
7c35ecf
@miaboloix
Turned two kt_android_library rules into one
dfd545a
@miaboloix
Added dependencies for test files
866a00a
@miaboloix
Deleted unnecessary dependencies and testing example file
2b9d7c6
@miaboloix
Fixed manifest issues
980ca88
@miaboloix
Move google json file
a63ad7f
@miaboloix
Restore app version of json
fff3d89
@miaboloix
Merge branch 'test-git-copy' into stage1_bazel_utility
54a7728
@miaboloix
Edit TODO
c7cad13
@miaboloix
Deleted TODO
654328e
@miaboloix
Changed Firebase comment
a842aec
@miaboloix
Fixed merge conflicts
146f48a
@miaboloix
Added testing functionality from later PR
9360972
@miaboloix
Added comments to bzl files
705d195
@miaboloix
Added targetSDK to manifests
2b7be73
@miaboloix
Changed crashlytics_lib to crashlytics
0621744
@miaboloix
Merge branch 'stage1_bazel_utility' of https://github.com/oppia/oppia…
54ec7fb 
…-android into stage1_bazel_testing
@miaboloix
Changed testing_tests visibility
af931e9
@miaboloix
Fixed merge conflicts
d5ae13c
@miaboloix
Added comment to utility_test.bzl
4f8e77f
@miaboloix
Changed type of comment ticks
0b9c14a
@miaboloix
Merge branch 'stage1_bazel_testing' of https://github.com/oppia/oppia…
0291f7a 
…-android into introduce-bazel-roboelectric-testing
@miaboloix
Fixed typos and all tests pass
17c92b3
@miaboloix
Removed empty line
fc7170f
@miaboloix
Fixed merge conflicts
acbd392
@miaboloix
Fixed errors from merge
dc8ad13
@miaboloix
Added comments to data and domain BUILD files
53828c0
@miaboloix
Fixed indentation in domain_test
578ef76
@miaboloix
Removed commented-out dependencies
65eaa1d
@miaboloix
Started convertin correct_answer to interaction object
818440a
@miaboloix miaboloix self-assigned this Jul 30, 2020
Base automatically changed from introduce-domain-bazel-build to develop August 17, 2020 15:44
@BenHenning BenHenning closed this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miaboloix miaboloix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GaeSolution's 'correct_answer' field should be 'Any?' instead of 'String?'
2 participants
@miaboloix @BenHenning