Move Bazel ownership to end of codeowners file #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rt4914 PTAL for codeowner adjustment. @fsharpasharp PTAL for policy change in how we manage Bazel owners. @seanlip PTAL as codeowner owner. |
fsharpasharp
approved these changes
Apr 27, 2021
seanlip
approved these changes
May 10, 2021
Undo post-merge conflict mistake.
Remove post-merge conflict code duplication.
|
Thanks @seanlip & others. I addressed the conflicts & will enable auto-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This updates Bazel code ownership to ensure that all Bazel files are reviewed by the same team members regardless of local directory ownership. This is becoming more important now that modules are being split up, and because the team isn't yet fully ramped up on maintaining BUILD files.
Note that BUILD file code ownership is a temporary situation. Once the migration from Gradle is complete & we have comprehensive Bazel documentation, we'll be expecting directory-level code owners to take over BUILD file ownership.
This was discovered when reviewing #2959: #2959 (review).