Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #414: Add StringToFractionParserTest #3214

Merged
merged 2 commits into from
May 21, 2021
Merged

Fix #414: Add StringToFractionParserTest #3214

merged 2 commits into from
May 21, 2021

Conversation

viktoriias
Copy link
Contributor

Explanation

Fixes #414: Add unit tests for StringToFractionParser.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@viktoriias viktoriias requested a review from rt4914 as a code owner May 20, 2021 17:13
@viktoriias
Copy link
Contributor Author

viktoriias commented May 20, 2021

@rt4914 Please review. Some imports have moved to the new packages, I updated the imports here.

@rt4914
Copy link
Contributor

rt4914 commented May 21, 2021

I have checked tests for this file and other app layer tests for robolectric and espresso and all tests are passing. I suppose the only solution is to merge this and check if this creates test failure once again or not.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 merged commit 808c205 into oppia:develop May 21, 2021
@rt4914
Copy link
Contributor

rt4914 commented May 21, 2021

Again checked all tests on latest develop and they are passing correctly which was not the case earlier.

@rt4914
Copy link
Contributor

rt4914 commented May 21, 2021

Created #3215 to test on CI

@rt4914 rt4914 mentioned this pull request May 21, 2021
8 tasks
@rt4914
Copy link
Contributor

rt4914 commented May 21, 2021

Confirmed in #3215 tests are now passing on CI too. Thanks @viktoriias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for whitespace & fractions patterns
2 participants