Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #3251: Added hint to numeric input #3253

Merged
merged 4 commits into from
Jun 22, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 25, 2021

Explanation

Fixes part of #3251: Added hint to numeric input

Before this PR the tests were failing if we enable the AccessibilityChecks.

Screenshot 2021-05-26 at 12 15 58 AM

Screenshot 2021-05-26 at 12 52 09 AM

Also a total of 15 tests cases were failing before this PR but now its 9 which are because of DragAndDropInteraction, which will get fixed in #2323

Screenshot 2021-05-26 at 1 11 26 AM

NOTE to REVIEWER: You cannot run this PR as it needs code from #3246 too which we cannot merge until and unless this and other similar PRs get merged.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from BenHenning May 25, 2021 19:44
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. Can you also add a test to verify that the correct hint is set?

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning May 27, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Jun 7, 2021

Screenshot 2021-06-07 at 6 07 15 PM

New added test is passing on espresso.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Jun 7, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test. Thanks @rt4914!

@BenHenning BenHenning merged commit 6a7e596 into develop Jun 22, 2021
@BenHenning BenHenning deleted the fix-a11y-checks-numeric branch June 22, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants