Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3199: [RTL] High-fi Profile chooser screen #3256

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented May 26, 2021

Explanation

This PR fixes #3199. Fixes the spacing issue in between the Profile image and the name.

Note :
Please test this PR with tablet as I was not able to test this on my emulator.

Screenshot LTR and RTL

screenshot ...... screenshot

screenshot....... screenshot
screenshot ...... screenshot

screenshot ..... screenshot

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this please add screenshots for tablet (portrait + landscape) and mobile landscape too as the UI for landscape mode is quite different.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 May 26, 2021
@veena14cs
Copy link
Contributor Author

veena14cs commented May 26, 2021

In this please add screenshots for tablet (portrait + landscape) and mobile landscape too as the UI for landscape mode is quite different.

@rt4914 I was unable to test on tablet emulator, could you please check it and assign someone to test on tablet and send screenshot.
I have updated landscape screenshot for phone in the description.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs May 26, 2021
@veena14cs veena14cs requested a review from rt4914 May 26, 2021 18:14
@rt4914
Copy link
Contributor

rt4914 commented May 28, 2021

@veena14cs On Tablet device the RTL is not working. Please take a look.


@rt4914 rt4914 assigned veena14cs and unassigned rt4914 May 28, 2021
@veena14cs
Copy link
Contributor Author

@veena14cs On Tablet device the RTL is not working. Please take a look.


Thanks for these screenshots Rajat! I will make corrections and update the PR.

@veena14cs
Copy link
Contributor Author

@veena14cs On Tablet device the RTL is not working. Please take a look.


@rt4914 I have updated Tablet screenshots in the description. PTAL.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment Jun 4, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jun 4, 2021
@rt4914 rt4914 merged commit de758e3 into oppia:develop Jun 4, 2021
@veena14cs veena14cs deleted the rtl-profile-chooser branch June 4, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Profile Chooser
2 participants