Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2761 #2769 #3125: Remove Bazel model library. #3262

Merged
merged 9 commits into from
Jun 1, 2021
Merged

Fix #2761 #2769 #3125: Remove Bazel model library. #3262

merged 9 commits into from
Jun 1, 2021

Conversation

fsharpasharp
Copy link
Contributor

@fsharpasharp fsharpasharp commented May 31, 2021

Explanation

Fix #2761
Fix #2769
Fix #3125

Subtitled_unicode_java_proto_lite seems to be indirectly exported by other libraries and was not added to any other library.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsharpasharp! LGTM.

@BenHenning BenHenning merged commit cdc93d2 into oppia:develop Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants