Fix #3268: Introduce Maven pinning artifacts Mechanism

[prayutsu]

Explanation

Fixes #3268:
Introduced Pinning Artifacts mechanism for Maven dependencies.

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[prayutsu]

@rt4914 PTAL.

[prayutsu]

It looks like the fail_if_repin_reqired attribute isn't set properly (as Bazel Lint test is failing and also Build is not failing upon editing Maven dependencies).
It seems fail_if_repin_required is declared as a variable rather than an attribute.

[prayutsu]

@rt4914 @BenHenning Should I update the CODEOWNERS file to mention appropriate CODEOWNERS for maven_install.json?

[prayutsu]

@rt4914 @fsharpasharp PTAL.

[fsharpasharp]

Looks good to me.

[oppiabot]

Unassigning @fsharpasharp since they have already approved the PR.

[rt4914]

@prayutsu Update the code-owner file to mention Ben's name for maven file. Also assigning this to Ben.

[BenHenning]

@prayutsu apologies for the delayed review. PTAL at my latest comments--I think you might've made a mistake when changing WORKSPACE to point to third_party/maven_install.json.

Also, just to check: doesn't maven_install.json need to be moved to third_party/?

[BenHenning]

@prayutsu I think you need to add a CODEOWNERS entry for third_party/ (that can go to me). Also, it looks like the maven_install.json file needs to be regenerated.

Beyond that, the Gradle test failures seem to be #2844 which is disappointing--I thought that was addressed. Rerunning them should hopefully fix the issue.

[prayutsu]

@prayutsu I think you need to add a CODEOWNERS entry for third_party/ (that can go to me). Also, it looks like the maven_install.json file needs to be regenerated.

Beyond that, the Gradle test failures seem to be #2844 which is disappointing--I thought that was addressed. Rerunning them should hopefully fix the issue.

Done.

[BenHenning]

Thanks @prayutsu. Just two last quick comments.

[BenHenning]

Per previous runs, the compute affected tests script doesn't seem to produce any tests to run here, so skipping it since the last two runs have hung.

[BenHenning]

Thanks @prayutsu. This LGTM!

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.