-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3354:[RTL] High-fi Interaction View #3355
Fix #3354:[RTL] High-fi Interaction View #3355
Conversation
@veena14cs Can you please update the description to correctly show the LTR vs RTL screenshots. Also, why is hint not showing RTL behaviour? If its because of non-strings.xml line then in that case can you add hint to |
I have updated Screenshots for LTR and RTL. The hint texts in screenshot are hardcoded in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veena14cs PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veena14cs Suggested nit changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@veena14cs Update with latest develop. |
Explanation
This PR fixes #3354 , This Pr fixes NumberInput, TextInput, Fractions and Ratios Interaction View.
Screenshot RTL
Mobile
.......
.....
.......
........
......
.........
,,,,
......
Tablet
.......
..........
...........
.........
.......
.......
.......
..........
Checklist