Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3354:[RTL] High-fi Interaction View #3355

Merged
merged 20 commits into from
Jul 4, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Jun 21, 2021

Explanation

This PR fixes #3354 , This Pr fixes NumberInput, TextInput, Fractions and Ratios Interaction View.

Screenshot RTL

Mobile

screenshot.......screenshot
screenshot..... screenshot

screenshot.......screenshot

screenshot........screenshot

screenshot.....screenshot.

screenshot.........screenshot

screenshot,,,, screenshot
screenshot......screenshot

Tablet
screenshot....... screenshot

screenshot..........screenshot

screenshot...........screenshot

screenshot.........screenshot

screenshot.......screenshot

screenshot.......screenshot

screenshot.......screenshot

screenshot..........screenshot

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor

rt4914 commented Jun 23, 2021

@veena14cs Can you please update the description to correctly show the LTR vs RTL screenshots.

Also, why is hint not showing RTL behaviour? If its because of non-strings.xml line then in that case can you add hint to NumericInput via strings.xml and then use that produce LTR vs RTL screenshots.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Jun 23, 2021
@veena14cs
Copy link
Contributor Author

@veena14cs Can you please update the description to correctly show the LTR vs RTL screenshots.

Also, why is hint not showing RTL behaviour? If its because of non-strings.xml line then in that case can you add hint to NumericInput via strings.xml and then use that produce LTR vs RTL screenshots.

I have updated Screenshots for LTR and RTL. The hint texts in screenshot are hardcoded in strings.xml for testing purpose, the actual values of hints are not changed in this PR.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veena14cs PTAL

@rt4914 rt4914 removed their assignment Jun 26, 2021
@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jun 28, 2021
@veena14cs veena14cs requested a review from rt4914 June 28, 2021 17:57
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veena14cs Suggested nit changes.

app/src/main/res/values-land/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values-sw600dp-land/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values-sw600dp-land/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values-sw600dp-port/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values-sw600dp-port/dimens.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Jun 29, 2021
@veena14cs veena14cs requested a review from rt4914 June 30, 2021 18:44
@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jun 30, 2021
@veena14cs veena14cs added this to the RTL Support milestone Jul 2, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914
Copy link
Contributor

rt4914 commented Jul 3, 2021

@veena14cs Update with latest develop.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Jul 3, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jul 3, 2021
@veena14cs veena14cs merged commit 6716b6e into oppia:develop Jul 4, 2021
@veena14cs veena14cs deleted the fix-number-fraction-interaction branch July 4, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Interaction View
2 participants