Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3356:[RTL] High-fi Coming Soon Topics card #3357

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Fix #3356:[RTL] High-fi Coming Soon Topics card #3357

merged 2 commits into from
Jun 26, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Jun 22, 2021 •
edited

Explanation

This PR fixes #3356 . This PR fixes the coming soon banner for RTL.

Screenshot LTR and RTL

Mobile
screenshot.... screenshot
screenshot..... screenshot

Tablet
screenshot........screenshot
screenshot......... screenshot

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs veena14cs requested a review from rt4914 as a code owner June 22, 2021 07:04
rt4914
rt4914 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

rt4914
rt4914 suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veena14cs Define both these colors in colors.xml file so that when one value is changed it gets reflected in LTR and RTL both

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Jun 23, 2021
@veena14cs
Copy link
Contributor Author

@veena14cs Define both these colors in colors.xml file so that when one value is changed it gets reflected in LTR and RTL both

Done.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jun 24, 2021
rt4914
rt4914 approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 23d6824 into oppia:develop Jun 26, 2021
@veena14cs veena14cs deleted the fix-coming-soon-topics-card branch July 5, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Coming Soon Topics card
2 participants
@veena14cs @rt4914