Fix part #164: Hifi content card

[veena14cs]

Explanation

This Pr corresponds to Content-cards and feedback

Known Issues

• Explorations data has no image. Need data with image. Resolved

• There is already padding for some of the text data from JSON file. So its showing too much padding for some of the contents. Resolved here

• Images are not center aligned.

Mock

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/b7069e13-ae14-44ca-ac1c-c96d43c8f3c4/PM-Q2-CA-Continue-

Screenshot

[rt4914]

Explanation

This Pr corresponds to Content-cards and feedback

Known Issues

• Explorations data has no image. Need data with image
• There is already padding for some of the text data from JSON file. So its showing too much padding for some of the contents.

Mock

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/b7069e13-ae14-44ca-ac1c-c96d43c8f3c4/PM-Q2-CA-Continue-

Screenshot

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs please mention these issues in High Fidelity Mock document too.

[rt4914]

LGTM, nit changes.

[rt4914]

@veena14cs I am unassigning @BenHenning and @seanlip from this, considering, this will be merged and then refinalised in Deadline2.

[nikitamarysolomanpvt]

I'am unassigning me please do the nit changes and assign back to me.

[veena14cs]

Resolved Padding issue by using trim() of String.

[rt4914]

Looks really great now.

[veena14cs]

Exploration data with image.

[veena14cs]

Exploration data with image.

Issue in this screenshot is bullets. There is new line tag in json data, so the text that has bullets is shown in the new line and with tabs. @BenHenning @rt4914 @seanlip @nikitamarysolomanpvt I need your suggestion on this what we can do for this. For debugging I removed \n\t from json data and here is how it looks.

[seanlip]

Does the JSON data match the JSON data from the server? @vinitamurthi

I think what you've done is fine as a temporary solution, but if the original data matches then we should file an issue to figure out what is going wrong.

Also, the bullets still don't look right. Shouldn't they have spacing around them? I assume they are ul/li elements? I would expect them to look like:

• Item 1
• Item 2

[veena14cs]

Does the JSON data match the JSON data from the server? @vinitamurthi

I think what you've done is fine as a temporary solution, but if the original data matches then we should file an issue to figure out what is going wrong.

Also, the bullets still don't look right. Shouldn't they have spacing around them? I assume they are ul/li elements? I would expect them to look like:

• Item 1
• Item 2

Yes you are correct, but when I am removing \n\t I am getting in this form. If I remove only \n it is not making any changes. Below is the data
<ul><li><p><strong>What a "ratio" is</strong></p></li><li><p><strong>How to write ratios using a colon, e.g. “2:3”.</strong></p></li></ul>

[seanlip]

Is there a lot of \n\t all over the JSON file? If so then maybe this is an end-of-line encoding issue and we need to strip this stuff out before storing/displaying the JSON. /cc @BenHenning @vinitamurthi

[veena14cs]

Yes, here is the original line of data containing bullets. \n\n<ul>\n\t<li>\n\t<p><strong>What a \"ratio\" is</strong></p>\n\t</li>\n\t<li>\n\t<p><strong>How to write ratios using a colon, e.g. “2:3”.</strong></p>\n\t</li>\n</ul>\n\n

…

On Fri, Nov 15, 2019 at 3:04 PM Sean Lip ***@***.***> wrote: Is there a lot of \n\t all over the JSON file? If so then maybe this is an end-of-line encoding issue and we need to strip this stuff out before storing/displaying the JSON. /cc @BenHenning <https://github.com/BenHenning> @vinitamurthi <https://github.com/vinitamurthi> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#338?email_source=notifications&email_token=AD4LXZBJFJ22QF42IFYBEBLQTZUL3A5CNFSM4JM254BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEE3TGA#issuecomment-554285464>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4LXZG3A5ZCOYHPJZLXDMTQTZUL3ANCNFSM4JM254BA> .

[seanlip]

Looks like the \n\t correspond to whitespace in the original HTML file. But generally extra whitespace in HTML should not alter how it's presented? (I'm not sure about the Android quirks though.)

[BenHenning]

I thought at one point we were replacing \n with
, but I couldn't find that anywhere. It does look like an importing error @vinitamurthi. Any ideas?

[BenHenning]

Let's submit this without the proper HTML parsing--I filed #361 to tack that work.

[BenHenning]

This should also fix #372.

[veena14cs]

Let's submit this without the proper HTML parsing--I filed #361 to tack that work.

Okay I will create this work in seperate PR.

[veena14cs]

#361

Here is the PR for this fix #404