Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3378: Arrange the list of activities in alphabetical order in ActivityComponent. #3398

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Fix #3378: Arrange the list of activities in alphabetical order in ActivityComponent. #3398

merged 2 commits into from
Jul 2, 2021

Conversation

ayush0402
Copy link
Contributor

Explanation

Fixes #3378
Arranged the list of activities in ActivityComponent.kt alphabetically.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@ayush0402 ayush0402 requested a review from rt4914 as a code owner July 2, 2021 05:58
@ayush0402
Copy link
Contributor Author

@rt4914 PTAL.

@oppiabot oppiabot bot assigned rt4914 Jul 2, 2021
rt4914
rt4914 suggested changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change suggested.

app/src/main/java/org/oppia/android/app/activity/ActivityComponent.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned ayush0402 and unassigned rt4914 Jul 2, 2021
rt4914
rt4914 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit c6bd904 into oppia:develop Jul 2, 2021
@ayush0402 ayush0402 deleted the alphabetical-activitycomponent branch July 2, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@ayush0402 ayush0402

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrange the list of activities in alphabetical order in ActivityComponent
2 participants
@ayush0402 @rt4914