Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3386: Introduce a PlatformParameterController #3430

Merged
merged 5 commits into from
Jul 8, 2021

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Jul 7, 2021

Explanation

Fixes #3386
Introduce a domain level Controller for Platform Parameter. This PR is replica of #3387 (it was completely approved but got closed accidentally).

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@vinitamurthi vinitamurthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was already reviewed and approved previously but because of a problem with the commit, a new PR was created so I'm approving it now again

@oppiabot
Copy link

oppiabot bot commented Jul 7, 2021

Unassigning @vinitamurthi since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jul 7, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 7, 2021

Hi @Arjupta, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@vinitamurthi vinitamurthi merged commit f640500 into develop Jul 8, 2021
@vinitamurthi vinitamurthi deleted the platform-parameter-cache-controller branch July 8, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a domain level Controller for Platform Parameters
2 participants