Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3424 Merge concept_card_fragment into single xml file #3443

Merged
merged 10 commits into from
Jul 9, 2021

Conversation

vrajdesai78
Copy link
Contributor

Explanation

I have merged concept_card_fragment.xml file into single file. I have added values in dimens.xml according to screen sizes.

Screenshots before merging into single file.

Screenshots after merging into single file

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@vrajdesai78 vrajdesai78 requested a review from rt4914 as a code owner July 8, 2021 08:36
@rt4914 rt4914 self-assigned this Jul 8, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrajdesai78 Suggested nit changes.

app/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
app/src/main/res/values-land/dimens.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned vrajdesai78 and unassigned rt4914 Jul 8, 2021
@vrajdesai78
Copy link
Contributor Author

@rt4914 I have done required changes. Kindly review it.

@rt4914 rt4914 assigned rt4914 and unassigned vrajdesai78 Jul 9, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914
Copy link
Contributor

rt4914 commented Jul 9, 2021

@vrajdesai78 Please make sure that the comments are resolved by the person who started them. You can comment on the threads mentioning if you have addressed it or not.

@oppiabot oppiabot bot unassigned rt4914 Jul 9, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 9, 2021

Unassigning @rt4914 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jul 9, 2021
@rt4914 rt4914 merged commit ada699e into oppia:develop Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants