-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3424 Merge concept_card_fragment into single xml file #3443
Fix #3424 Merge concept_card_fragment into single xml file #3443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrajdesai78 Suggested nit changes.
@rt4914 I have done required changes. Kindly review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@vrajdesai78 Please make sure that the comments are resolved by the person who started them. You can comment on the threads mentioning if you have addressed it or not. |
Unassigning @rt4914 since they have already approved the PR. |
Explanation
I have merged concept_card_fragment.xml file into single file. I have added values in dimens.xml according to screen sizes.
Screenshots before merging into single file.
Screenshots after merging into single file
Checklist