Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3419: Separate ViewEventLogsActivityTest into activity and fragment test files #3468

Merged
merged 16 commits into from
Aug 5, 2021
Merged

Fix #3419: Separate ViewEventLogsActivityTest into activity and fragment test files #3468

merged 16 commits into from
Aug 5, 2021

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Jul 13, 2021 •
edited

Explanation

Fixes #3419. Separated ViewEventLogsActivityTest into activity and fragment test files.

Screenshots

  • Expresso test results for ViewEventLogsActivityTest
    Screenshot from 2021-07-22 18-47-48

  • Expresso test results for ViewEventLogsFragmentTest
    Screenshot from 2021-07-22 18-44-03

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@yashraj-01 yashraj-01 requested a review from rt4914 as a code owner July 13, 2021 09:52
@github-actions
Copy link

Hi! @yashraj-01 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

@yashraj-01
Copy link
Contributor Author

yashraj-01 commented Jul 13, 2021 •
edited

Hi! @yashraj-01 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

@rt4914 PTAL.

BenHenning
BenHenning reviewed Jul 13, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for this PR--same comments as #3471 apply here. PTAL.

@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Jul 13, 2021
@rt4914 rt4914 removed their assignment Jul 19, 2021
@yashraj-01
Copy link
Contributor Author

I have updated this PR as per comments on #3471. PTAL. Thanks.

@BenHenning
Copy link
Sponsor Member

Deferring to @Sarthak2601 for the initial main reviews per #3471.

@BenHenning BenHenning removed their assignment Jul 23, 2021
Sarthak2601
Sarthak2601 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

rt4914
rt4914 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment Jul 26, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 30, 2021

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jul 30, 2021
@BenHenning
Copy link
Sponsor Member

@yashraj-01 it looks like the static checks are failing & the exemption list may need to be updated.

BenHenning
BenHenning requested changes Jul 30, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes due to failing CI.

@oppiabot oppiabot bot removed the PR: LGTM label Jul 30, 2021
@yashraj-01
Copy link
Contributor Author

yashraj-01 commented Jul 30, 2021 •
edited

Requesting changes due to failing CI.

@BenHenning are we having activity labels for test activities as well?

@oppiabot
Copy link

oppiabot bot commented Jul 30, 2021

Hi, @yashraj-01, the LGTM Label has been removed because the changes were requested on this PR. Thanks!.

@yashraj-01
Copy link
Contributor Author

Requesting changes due to failing CI.

@BenHenning are we having activity labels for test activities as well?

Added test activities to exemption list

@yashraj-01 yashraj-01 removed their assignment Jul 30, 2021
@Sparsh1212 Sparsh1212 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Jul 30, 2021
@yashraj-01 yashraj-01 removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Jul 30, 2021
BenHenning
BenHenning reviewed Aug 4, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01! LGTM, just one comment--PTAL.

app/src/sharedTest/java/org/oppia/android/app/devoptions/ViewEventLogsFragmentTest.kt Show resolved Hide resolved
@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Aug 4, 2021
@yashraj-01 yashraj-01 assigned BenHenning and unassigned yashraj-01 Aug 4, 2021
BenHenning
BenHenning approved these changes Aug 5, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01. LGTM!

@BenHenning BenHenning merged commit 3f98e53 into oppia:develop Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

@Sarthak2601 Sarthak2601 Sarthak2601 approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate ViewEventLogsActivityTest into activity and fragment test files
5 participants
@yashraj-01 @BenHenning @rt4914 @Sarthak2601 @Sparsh1212