Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3420: Separate MarkChaptersCompletedActivityTest into activity and fragment test files #3469

Merged
merged 8 commits into from
Jul 30, 2021
Merged

Fix #3420: Separate MarkChaptersCompletedActivityTest into activity and fragment test files #3469

merged 8 commits into from
Jul 30, 2021

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Jul 13, 2021 •
edited

Explanation

Fixes #3420. Separated MarkChaptersCompletedActivityTest into activity and fragment test files.

Screenshots

  • Expresso test results for MarkChaptersCompletedActivityTest
    Screenshot from 2021-07-22 18-19-00

  • Expresso test results for MarkChaptersCompletedFrgmentTest
    Screenshot from 2021-07-22 18-12-59

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@github-actions
Copy link

Hi! @yashraj-01 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

BenHenning
BenHenning reviewed Jul 13, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for this PR--same comments as #3471 apply here. PTAL.

@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Jul 13, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jul 14, 2021

Please add screenshot showing that Espresso Tests are passing for the files modified in this PR. Also once @BenHenning 's comments are resolved and fixed just ping me so that I can check it accordingly.

@rt4914 rt4914 removed their assignment Jul 19, 2021
@yashraj-01
Copy link
Contributor Author

I have updated the PR as per comments on #3471. PTAL. Thanks.

@BenHenning
Copy link
Sponsor Member

Deferring to @Sarthak2601 for the main reviews per #3471.

@BenHenning BenHenning removed their assignment Jul 23, 2021
Sarthak2601
Sarthak2601 suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01. Left some thoughts regarding configChanges.

app/src/sharedTest/java/org/oppia/android/app/devoptions/MarkChaptersCompletedFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/devoptions/MarkChaptersCompletedFragmentTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/devoptions/MarkChaptersCompletedFragmentTest.kt Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Unassigning @Sarthak2601 since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Hi @yashraj-01, it looks like some changes were requested on this pull request by @Sarthak2601. PTAL. Thanks!

rt4914
rt4914 suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashraj-01 PTAL.

app/src/main/res/layout/mark_chapters_completed_fragment.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Jul 26, 2021
@yashraj-01 yashraj-01 mentioned this pull request Jul 27, 2021
Merged
8 tasks
@yashraj-01 yashraj-01 requested a review from rt4914 July 27, 2021 09:54
@yashraj-01 yashraj-01 assigned Sarthak2601 and unassigned yashraj-01 Jul 27, 2021
@rt4914 rt4914 assigned yashraj-01 and unassigned rt4914 Jul 28, 2021
Sarthak2601
Sarthak2601 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 29, 2021

Assigning @rt4914 for code owner reviews. Thanks!

@yashraj-01 yashraj-01 removed their assignment Jul 29, 2021
rt4914
rt4914 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 removed their assignment Jul 29, 2021
BenHenning
BenHenning approved these changes Jul 30, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01! LGTM.

@BenHenning BenHenning merged commit 7e71563 into oppia:develop Jul 30, 2021
@yashraj-01 yashraj-01 mentioned this pull request Jul 30, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

@Sarthak2601 Sarthak2601 Sarthak2601 approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate MarkChaptersCompletedActivityTest into activity and fragment test files
4 participants
@yashraj-01 @rt4914 @BenHenning @Sarthak2601